[Mono-dev] Generic Variance

[Rodrigo Kumpera]

Hi Scott,

Some points about your code:

1)mono_class_has_variant_generic_params (MonoClass *klass)
Don't move functions around together with patches that add functionality.
Cleanups, when justifiable, are ok but must
be done on a separate refactoring only patch. On this case, please just add
a forward declaration on the top.

2)mono_class_is_assignable_from
Don't do unneeded changes to existing conditions that just make your patch
harder to read. By merging the two conditions your
patch got huge for no reason at all. Please revert this change so the patch
is smaller.

3)mono_class_interface_offset
This function is used to define layout of classes, vtables and the such. You
patch lacks neither a proper Changelog notice on why this change is needed
or tests that evidence it.


Thanks,
Rodrigo



2009/2/1 Scott Peterson <scott at ssblack.co.nz>

> This patch adds generic variance support to the C# compiler. This patch
> does not fully support the spec in that it provides variance only for
> reference types. This limitation is designed to reflect the current
> (proposed) level of variance support in the VM. New error codes are defined
> and tests for each code are provided, as well as tests for variance. This
> patch is contributed under the MIT/X11 license. It is attached.
>
> NOTE: This email is a re-send. The original also had the patch inline, but
> it was too long for the system. Blarg.
>
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090202/96b4e414/attachment.html