[Mono-dev] Compiler warnings

[Christian Hergert]

On Aug 16, 2009, at 5:04 PM, Rodrigo Kumpera wrote:

> About mono-printf-fixes, it looks fine expect I don't see the need  
> for the changes in mono-counters.c.
> The gssize one fixes a warning, but the others looks superfluous to  
> me - or is it because I'm doing a 32bits
> build?

Yes, this fixes the warnings for 64bit.

> The uninitialized-fixes.patch is ok to be committed.
>
> The declaration-fixes.pacth is good to be committed as well.
>
> The bitwise-branch-checks.path looks fine to go.
>
> explicit-word-size-changes are ok.
>
> I'm not sure about unused-functions.patch as those files are  
> basically external code we imported from
> other projects. I wonder what's the opinion of others on this matter.

This was my concern as well.  However, I noticed a few others that  
were commented out as well and the svn history seemed to show a  
pattern of modifying the files.

I'll go ahead and commit the others.

Thanks!

-- Christian