[Mono-dev] Compiler warnings

Rodrigo Kumpera kumpera at gmail.com
Sun Aug 16 20:04:59 EDT 2009


About mono-printf-fixes, it looks fine expect I don't see the need for the
changes in mono-counters.c.
The gssize one fixes a warning, but the others looks superfluous to me - or
is it because I'm doing a 32bits
build?

The uninitialized-fixes.patch is ok to be committed.

The declaration-fixes.pacth is good to be committed as well.

The bitwise-branch-checks.path looks fine to go.

explicit-word-size-changes are ok.

I'm not sure about unused-functions.patch as those files are basically
external code we imported from
other projects. I wonder what's the opinion of others on this matter.


On Tue, Aug 4, 2009 at 10:11 PM, Christian Hergert <chris at dronelabs.com>wrote:

> Hi,
>
> I've split the patches up based on their content. Attached.
>
> unused-functions.patch -  #if 0 unused functions in dlmalloc.c and strtod.c
> uninitialized-fixes.patch -  make sure variables are initialized with
> NULL/0 where used without initialization
> mono-printf-fixes.patch -  make sure a format string such as "%s" is used
> with variable string input printf() style methods
> explicit-word-size-changes.patch -  use GINT_TO_POINTER and such when
> converting from int32 to word-size
> declaration-fixes.patch -  Fix method declarations that have () instead of
> (void) and add missing non-static declarations
> bitwise-branch-checks.patch -  be explicit with parenthesis when using
> bitwise operation as implicit boolean
>
> I've omitted the patch for using write() without checking the result for
> now.  Let me know if you want to move forward with those and how we would
> want to do it properly.
>
> Thanks,
>
> -- Christian
>
>
>
>
> On Aug 4, 2009, at 6:11 AM, Rodrigo Kumpera wrote:
>
>  Hi Chistian,
>>
>> Your patch is full of very different kind of changes, some are simple,
>> others require some thought
>> about. So let's sort them into smaller and centered patches.
>>
>> For example, the ones changing printf style calls are mostly ok and should
>> be committed on their
>> own. Then we can see the warnings changes, the io retry stuff and finally
>> what looks like real bugs.
>>
>> What do you think about it?
>>
>> Rodrigo
>>
>>
>> On Fri, Jul 24, 2009 at 2:02 AM, Christian Hergert <chris at dronelabs.com>
>> wrote:
>> Round 2,
>>
>>  * Moved TEMP_FAILURE_RETRY macro to mono/utils/mono-io-portability.h.
>>  * Removed #ifndef PLATFORM_MACOSX for now.
>>
>> -- Christian
>>
>>
>>
>>
>>
>> On Jul 23, 2009, at 8:24 PM, Geoff Norton wrote:
>>
>> On 23-Jul-09, at 11:02 PM, Christian Hergert wrote:
>>
>> Hello,
>>
>> In an effort to get more familiar with some of the code-base, I went
>> through and fixed some of the pesky compiler warnings for the runtime.
>>  Attached is a patch for said warnings.
>>
>> If anyone has suggestions on how to better fix the warnings, please send
>> them my way and I'll adjust the patch as needed.
>>
>>
>> #1: Having tons of
>> +#ifndef TEMP_FAILURE_RETRY
>>
>> is sucky, localize it into mono/utils/somewhere-logical.h and include it
>> around
>>
>>
>> #2: lots of:
>> +#ifndef PLATFORM_MACOSX
>>       FILE *fp;
>> +#endif
>>
>> impedes readability (for me) just for 1 platform, not sure its worth it.
>>
>> As for the rest, it looks sane, but I'll let the runtime guys weigh in.
>>
>> -g
>>
>>
>>
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090816/7ea7fb44/attachment-0001.html 


More information about the Mono-devel-list mailing list