[Mono-dev] patch for dataset binary deserialization bugs

[Nagappan A]

Hi,

They are good to check in.

Thanks
Nagappan

2008/9/15 brandin claar <brandin.claar at gmail.com>

> I am attaching 2 diffs.  One is for the fixes, and the other is for 2
> additional unit tests.  I discovered another exception while trying to
> serialize a DataTable with zero rows, so I fixed that as well.  Ignore the
> previous patch because it doesn't have that fix.  All tests pass with my
> fix.  The 2 new tests fail without it.
>
> Thanks.
>
> -brandin
>
> On Sun, Sep 14, 2008 at 11:21 PM, Nagappan A <nagappan at gmail.com> wrote:
>
>> Hello,
>>
>> Also request to verify your changes doesn't affect existing tests like:
>>
>> make run-test PROFILE=net_2_0 ;#under class/System.Data directory
>>
>> Thanks
>> Nagappan
>>
>> 2008/9/14 brandin claar <brandin.claar at gmail.com>
>>
>>>  I found 2 bugs while trying to deserialize binary datasets from .NET:
>>>
>>> 1.  A column with a DefaultValue set to anything other than DBNull would
>>> throw an exception.
>>>
>>> 2.  A table with zero rows would throw an exception.
>>>
>>> I have attached the patch I used to solve these issues.  Let me know if
>>> I'm out of my mind.  This is my first foray into debugging Mono.
>>>
>>> Thanks.
>>>
>>> -brandin
>>>
>>> _______________________________________________
>>> Mono-devel-list mailing list
>>> Mono-devel-list at lists.ximian.com
>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>>
>>>
>>
>>
>> --
>> Linux Desktop (GUI Application) Testing Project -
>> http://ldtp.freedesktop.org
>> http://nagappanal.blogspot.com
>>
>
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>


-- 
Linux Desktop (GUI Application) Testing Project -
http://ldtp.freedesktop.org
http://nagappanal.blogspot.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080915/caac3fb1/attachment-0001.html