[Mono-dev] [PATCH] System.Diagnostics/Process fix

[Rodrigo Kumpera]

On Tue, Sep 9, 2008 at 5:56 PM, Bill Holmes <billholmes54 at gmail.com> wrote:

> > If it's not abusing of your good will. Please add some comments to
> > Process.cs, Sockets.cs and socket-io.h mentioning this
> > needs to be sync'ed in 3 places.
>
> I was thinking the same thing.  I will add that.
>
> > About stripping the '\r', won't that cause problems on unix machines?
>
> I will have to check.  The quick answer is that I don't think so.  I
> can remove this part of the patch for now as it is not mission
> critical to me.  I simply found it while I was debugging the first
> problem.
>
> To recap.
>
> I will add the comments.
> remove the \r checks
> commit to the trunk and branch
> look at the \r problem another day.
>
> -bill
>


Looks perfect.

Thanks,
Rodrigo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080909/a1b4cd06/attachment.html