[Mono-dev] [PATCH] System.Diagnostics/Process fix

Rodrigo Kumpera kumpera at gmail.com
Tue Sep 9 16:24:13 EDT 2008


Hey Bill,

The fix to sync ProcessAsyncReader fields looks ok.

If it's not abusing of your good will. Please add some comments to
Process.cs, Sockets.cs and socket-io.h mentioning this
needs to be sync'ed in 3 places.

About stripping the '\r', won't that cause problems on unix machines?

Thanks,
Rodrigo


2008/9/9 Bill Holmes <billholmes54 at gmail.com>

> Hello All,
>
> The attached patch fixes some problems I was having with
> Process.ErrorDataReceived and Process.BeginErrorReadLine.
>
> There are actually two fixes here.  The most critical is that the
> fields of ProcessAsyncReader dd not match MonoSocketAsyncResult.
>
> The second part removes the extra '\r' on windows when spitting the string.
>
> I also need this in the 2.0 branch.
>
> -bill
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080909/e9f0a4bc/attachment.html 


More information about the Mono-devel-list mailing list