[Mono-dev] [Mono-patches] r115240 - in trunk/mcs/class/System.Web.Extensions: . System.Web.UI.WebControls

[Atsushi Eno]

Hi Rodrigo,

Rodrigo Kumpera wrote:
> Hi Atsushi,
> 
> I got a few questions about your commit r115240.
> 
> Any reason to use "...GetSetMethod ().Invoke (entity, new object [] 
> {p.Value});" instead of just "..SetValue (entity, p.Value, null);"?
> They produce the same result.

Sure, no reason - I'll replace it later (it was for sort of debugging).

> The ExecuteInsert method does a lot of reflection searches for what 
> looks like a finite and small set of types. If this method
> end been called frequently enough it will be a performance bottleneck as 
> such calls are synchronized under a single lock.
> 
> It is a good a idea to cache the results of GetProperty() and 
> GetSetMethod().

Sure, will improve them. Thanks for the suggestion.

Atsushi Eno