[Mono-dev] revert of r104029/30/31

Andreas Färber andreas.faerber at web.de
Mon May 26 08:31:00 EDT 2008

Hello Sebastian,

Am 26.05.2008 um 13:45 schrieb Sebastien Pouliot:

> On Mon, 2008-05-26 at 12:20 +0200, Andreas Färber wrote:
>> Am 26.05.2008 um 11:23 schrieb Atsushi Eno:
>>> Changing parameter names may result in bugs (especially when
>>> there is a field that has the identical name). When it is mixed
>>> with line ending changes, it becomes very hard to identify the
>>> cause of the issue. Those changes should be done separately.
>> I was told so too, but Andreas N. was recently flamed for doing a
>> separate typo fix commit.
>> And review for such non-functional patches, while trivial and non-
>> breaking, appears to be handled with very low priority...
> Yes and I fail to see why non-functional, trivial patches should have
> nothing else than low priority.

Because, as you say, they should not go together with functional  
changes. :-)

So they either block your functional changes, or require to sync  
multiple SVN working copies, or require to switch from SVN to some  
distributed versioning system, to separate non-functional from  
functional changes. Think of working on multiple hosts and multiple  
overlapping issues.
I've learned Git now and am comfortable with separating the aspects by  
branches. Yet keeping the patches people need to apply for testing  
small seems saner, for SVN. Or if Git is the new way everyone is  
expected to provide and apply+test patches, then the repo location  
should be published officially on the Wiki instead of telling people  
to ask Raja by email.


More information about the Mono-devel-list mailing list