[Mono-dev] [PATCH] Fixes and improvements for mixed-mode assembly support

[Kornél Pál]

Hi,

> Besides that, can't the functions in coree.h be MONO_INTERNAL as well?

#if !defined(PLATFORM_WIN32) && HAVE_VISIBILITY_HIDDEN
#define MONO_INTERNAL __attribute__ ((visibility ("hidden")))
#else
#define MONO_INTERNAL
#endif

I think this makes no difference because coree.h is limited to Windows and I 
think that the way for running mixed-mode assemblies on Linux is to use Wine 
+ Mono for Windows. But I'll add MONO_INTERNAL to mark private functions.

Btw couldn't we use __attribute__ ((visibility ("hidden"))) on Windows as 
well and build mono.def for MSVC build from a Windows version instead of a 
Linux version?

Kornél

----- Original Message ----- 
From: "Rodrigo Kumpera" <kumpera at gmail.com>
To: "Kornél Pál" <kornelpal at gmail.com>
Cc: <mono-devel-list at lists.ximian.com>
Sent: Tuesday, May 13, 2008 6:49 PM
Subject: Re: [Mono-dev] [PATCH] Fixes and improvements for mixed-mode 
assembly support


Hi,

The patch look fine and can be committed, don't forget the licensing notice
on Changelog.

Besides that, can't the functions in coree.h be MONO_INTERNAL as well?

Thanks for the contribution,
Rodrigo



2008/5/13 Kornél Pál <kornelpal at gmail.com>:

> Hi,
>
> This is the patch without renaming and thread.c modification. Otherwise
> unmodified.
>
> Currently mixed mode assembly support is disabled so this patch would be
> needed for reenabling it.
>
> ChangeLog:
> * domain.c: Open exe_image anyway so that it can be fixed up. Add a
> mono_close_exe_image function that closes exe_image.
>
> * image.c: Fix reference counting when DLL image is loaded using
> LoadLibrary outside of image.c. The image was previously freed in this 
> case
> using FreeLibrary even when it's memory was referenced by metadata that
> caused the crash reported by Jonathan Chambers.
>
> * coree.c: Some improvements and add mono_set_act_ctx that loads manifest
> file from the main assembly when process is created from mono.exe. This is
> required for MSVCRT support but may be used by other assemblies as well 
> for
> example for XP Visual Style support.
>
> Please review the attached patch and if you like it please approve it.
>
> Kornél
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>