[Mono-dev] [PATCH] Fixes and improvements for mixed-mode assembly support

Rodrigo Kumpera kumpera at gmail.com
Tue May 13 12:49:18 EDT 2008


The patch look fine and can be committed, don't forget the licensing notice
on Changelog.

Besides that, can't the functions in coree.h be MONO_INTERNAL as well?

Thanks for the contribution,

2008/5/13 Kornél Pál <kornelpal at gmail.com>:

> Hi,
> This is the patch without renaming and thread.c modification. Otherwise
> unmodified.
> Currently mixed mode assembly support is disabled so this patch would be
> needed for reenabling it.
> ChangeLog:
> * domain.c: Open exe_image anyway so that it can be fixed up. Add a
> mono_close_exe_image function that closes exe_image.
> * image.c: Fix reference counting when DLL image is loaded using
> LoadLibrary outside of image.c. The image was previously freed in this case
> using FreeLibrary even when it's memory was referenced by metadata that
> caused the crash reported by Jonathan Chambers.
> * coree.c: Some improvements and add mono_set_act_ctx that loads manifest
> file from the main assembly when process is created from mono.exe. This is
> required for MSVCRT support but may be used by other assemblies as well for
> example for XP Visual Style support.
> Please review the attached patch and if you like it please approve it.
> Kornél
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080513/a75ac0e8/attachment.html 

More information about the Mono-devel-list mailing list