[Mono-dev] Sys.SM.Configuration changes caused too much regressions

[Atsushi Eno]

Turned out that you actually never logged changes to ChangeLog
(it is not about SVN commit log but about files named "ChangeLog".)

We (including you) should always log the changes in those files.

Atsushi Eno

Atsushi Eno wrote:
> No matter how it works in your machine, the tests are indeed broken
> as monobuild shows. See System.ServiceModel test results:
> http://mono.ximian.com/monobuild/python/monobuild.py
> http://mono.ximian.com/monobuild/builds/HEAD/suse-101-i586/olive/98880/logs/test.log
> 
> 
> BTW you always have meaningless ChangeLog entry such as:
> 
>> Log:
>> fix implementation, refactoring
> 
> but it is not true. For example for r98854 which you put *new file*
> which is neither implementation fix nor refactoring at all.
> 
> Atsushi Eno
> 
> 
> Igor Zelmanovich wrote:
>> Hello Atsushi,
>>
>> There was some not implemented API in System.Configuration
>> I've implemented it in r98680
>>
>> You have rebuild (and install) System.Configuration to have the tests
>> pass.
>>
>> I have no such regressions in my Ubuntu.
>>
>> If you still have any such regression, please send me exception's stack
>> trace.
>> Be sure I run nunit test suite each time I have commit.
>>
>> Igor Zelmanovich.
>>
>> -----Original Message-----
>> From: Atsushi Eno [mailto:atsushi at ximian.com] 
>> Sent: Friday, March 21, 2008 1:50 PM
>> To: Igor Zelmanovich
>> Cc: mono-devel-list at lists.ximian.com; mono-olive at googlegroups.com
>> Subject: Sys.SM.Configuration changes caused too much regressions
>>
>> Hello Igor,
>>
>> I usually don't care too much about NUnit test regressions in the
>> face of significant development in olive, but lately you broke too
>> much tests due to System.ServiceModel.Configuration improvements.
>> More than 10 tests now fails with NotImplementedException which
>> is raised inside configuration stuff.
>>
>> Please remove any configuration hook from existing working stuff
>> such as ChannelFactory. If you do not, I'll revert several things
>> instead next week, which could mess your work. Thanks in advance.
>>
>> Atsushi Eno
>>
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>