[Mono-dev] [Mono-patches] r107198 - trunk/mcs/class/corlib/System

[Mirco Bauer]

Hi Andreas,

my reply is inline, see below.

On Fri, 2008-07-04 at 08:59 +0200, Andreas Nahr wrote:
> In Text
> 
> > -----Ursprüngliche Nachricht-----
> > Von: Mirco Bauer [mailto:meebey at meebey.net]
> > Gesendet: Freitag, 4. Juli 2008 01:52
> > An: mono-devel-list at lists.ximian.com
> > Cc: ClassDevelopment at A-SoftTech.com
> > Betreff: Re: [Mono-patches] r107198 - trunk/mcs/class/corlib/System
> > 
> > On Thu, 2008-07-03 at 18:23 -0400, Andreas Nahr
> > (ClassDevelopment at A-SoftTech.com) wrote:
> > > Author: andreas
> > > Date: 2008-07-03 18:23:54 -0400 (Thu, 03 Jul 2008)
> > > New Revision: 107198
> > >
> > > Modified:
> > >    trunk/mcs/class/corlib/System/ChangeLog
> > >    trunk/mcs/class/corlib/System/IntPtr.cs
> > > Log:
> > > 2008-07-04  Andreas Nahr <ClassDevelopment at A-SoftTech.com>
> > >
> > > 	* IntPtr: Fix parameter names, change internal name to accomodate
> > for parameter changes
> > >
> > > Modified: trunk/mcs/class/corlib/System/ChangeLog
> > > ===================================================================
> > > --- trunk/mcs/class/corlib/System/ChangeLog	2008-07-03 22:22:43 UTC
> > (rev 107197)
> > > +++ trunk/mcs/class/corlib/System/ChangeLog	2008-07-03 22:23:54 UTC
> > (rev 107198)
> > > @@ -1,5 +1,9 @@
> > >  2008-07-04  Andreas Nahr <ClassDevelopment at A-SoftTech.com>
> > >
> > > +	* IntPtr: Fix parameter names, change internal name to accomodate
> > for parameter changes
> > > +
> > > +2008-07-04  Andreas Nahr <ClassDevelopment at A-SoftTech.com>
> > > +
> > >  	* Predicate.cs:
> > >  	* Object.cs:
> > >  	* Nullable.cs
> > >
> > > Modified: trunk/mcs/class/corlib/System/IntPtr.cs
> > > ===================================================================
> > > --- trunk/mcs/class/corlib/System/IntPtr.cs	2008-07-03 22:22:43 UTC
> > (rev 107197)
> > > +++ trunk/mcs/class/corlib/System/IntPtr.cs	2008-07-03 22:23:54 UTC
> > (rev 107198)
> > > @@ -57,44 +57,44 @@
> > >  #endif
> > >  	public unsafe struct IntPtr : ISerializable
> > >  	{
> > > -		private void *value;
> > > +		private void *m_value;
> > 
> > I am not sure, but doesn't this break binary serialization
> > compatibility?
> 
> It shouldn't. IntPtr has an explicit Serializer implementation that deals
> with setting correct names. I did not change those.

Oh ok, didn't see that (from the patch).

> 
> > >
> > >  		public static readonly IntPtr Zero;
> > >
> > >  #if NET_2_0
> > >  		[ReliabilityContract (Consistency.MayCorruptInstance,
> > Cer.MayFail)]
> > >  #endif
> > > -		public IntPtr (int i32)
> > > +		public IntPtr (int value)
> > >  		{
> > > -			value = (void *) i32;
> > > +			m_value = (void *) value;
> > 
> > afaik the goal can also be archived using this.value = value;
> 
> Did you try that? I actually had it this way and it refused to compile
> because the value was deemed not initialized. I've got to admit that I
> wasn't exactly sure why it didn't. Potential issue with the compiler maybe?

At least for me it works, using gmcs 1.9.1:

meebey at redbull:~$ cat test.cs
using System;

class Test
{
	int value;

	Test(int value)
	{
		this.value = value;
	}

	public static void Main ()
	{
		Test t = new Test(123);
		Console.WriteLine(t.value);
	}
}
meebey at redbull:~$ mono test.exe
123
meebey at redbull:~$ 

I just find a bit intrusive/overkill to rename class members because of
parameter names of some ctor or method... (especially when they come
from MS .NET) as it might have side-effects like serialization comp for
classes that don't have an explicit implementation.

Thanks for your effort.

-- 
Regards,

Mirco 'meebey' Bauer

PGP-Key ID: 0xEEF946C8

FOSS Developer    meebey at meebey.net  http://www.meebey.net/
PEAR Developer    meebey at php.net     http://pear.php.net/
Debian Developer  meebey at debian.org  http://www.debian.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: This is a digitally signed message part
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080704/a09c889d/attachment.bin