[Mono-dev] [Mono-patches] r107198 - trunk/mcs/class/corlib/System

[Andreas Nahr]

In Text

> -----Ursprüngliche Nachricht-----
> Von: Mirco Bauer [mailto:meebey at meebey.net]
> Gesendet: Freitag, 4. Juli 2008 01:52
> An: mono-devel-list at lists.ximian.com
> Cc: ClassDevelopment at A-SoftTech.com
> Betreff: Re: [Mono-patches] r107198 - trunk/mcs/class/corlib/System
> 
> On Thu, 2008-07-03 at 18:23 -0400, Andreas Nahr
> (ClassDevelopment at A-SoftTech.com) wrote:
> > Author: andreas
> > Date: 2008-07-03 18:23:54 -0400 (Thu, 03 Jul 2008)
> > New Revision: 107198
> >
> > Modified:
> >    trunk/mcs/class/corlib/System/ChangeLog
> >    trunk/mcs/class/corlib/System/IntPtr.cs
> > Log:
> > 2008-07-04  Andreas Nahr <ClassDevelopment at A-SoftTech.com>
> >
> > 	* IntPtr: Fix parameter names, change internal name to accomodate
> for parameter changes
> >
> > Modified: trunk/mcs/class/corlib/System/ChangeLog
> > ===================================================================
> > --- trunk/mcs/class/corlib/System/ChangeLog	2008-07-03 22:22:43 UTC
> (rev 107197)
> > +++ trunk/mcs/class/corlib/System/ChangeLog	2008-07-03 22:23:54 UTC
> (rev 107198)
> > @@ -1,5 +1,9 @@
> >  2008-07-04  Andreas Nahr <ClassDevelopment at A-SoftTech.com>
> >
> > +	* IntPtr: Fix parameter names, change internal name to accomodate
> for parameter changes
> > +
> > +2008-07-04  Andreas Nahr <ClassDevelopment at A-SoftTech.com>
> > +
> >  	* Predicate.cs:
> >  	* Object.cs:
> >  	* Nullable.cs
> >
> > Modified: trunk/mcs/class/corlib/System/IntPtr.cs
> > ===================================================================
> > --- trunk/mcs/class/corlib/System/IntPtr.cs	2008-07-03 22:22:43 UTC
> (rev 107197)
> > +++ trunk/mcs/class/corlib/System/IntPtr.cs	2008-07-03 22:23:54 UTC
> (rev 107198)
> > @@ -57,44 +57,44 @@
> >  #endif
> >  	public unsafe struct IntPtr : ISerializable
> >  	{
> > -		private void *value;
> > +		private void *m_value;
> 
> I am not sure, but doesn't this break binary serialization
> compatibility?

It shouldn't. IntPtr has an explicit Serializer implementation that deals
with setting correct names. I did not change those.

> >
> >  		public static readonly IntPtr Zero;
> >
> >  #if NET_2_0
> >  		[ReliabilityContract (Consistency.MayCorruptInstance,
> Cer.MayFail)]
> >  #endif
> > -		public IntPtr (int i32)
> > +		public IntPtr (int value)
> >  		{
> > -			value = (void *) i32;
> > +			m_value = (void *) value;
> 
> afaik the goal can also be archived using this.value = value;

Did you try that? I actually had it this way and it refused to compile
because the value was deemed not initialized. I've got to admit that I
wasn't exactly sure why it didn't. Potential issue with the compiler maybe?

> thats all, thanks.
> 
> --
> Regards,
> 
> Mirco 'meebey' Bauer
> 
> PGP-Key ID: 0xEEF946C8
> 
> FOSS Developer    meebey at meebey.net  http://www.meebey.net/
> PEAR Developer    meebey at php.net     http://pear.php.net/
> Debian Developer  meebey at debian.org  http://www.debian.org/