[Mono-dev] [PATCH] corlib GetCustomAttributes for overriden properties bug
Raja R Harinath
harinath at hurrynot.org
Tue Feb 26 00:47:46 EST 2008
"Ivan N. Zlatev" <contact at i-nz.net> writes:
> On Mon, Feb 25, 2008 at 9:43 PM, Ivan N. Zlatev <contact at i-nz.net> wrote:
>> Please review the attached patch that fixes our behavior to match MS's
>> in terms of GetCustomAttributes for overridden attributes on
>> properties. That is:
>> * PropertyInfo.GetCustomAttributes - Inherit parameter is ignored and
>> behavior defaults to false
>> * Attributes.GetCustomAttributes - Inherit parameter is not ignored
>> * Attributes.IsDefined - Inherit parameter is not ignored on the 2.0 profile.
>> This patch fixes bugs #324472 and #322464. Also now all our Attribute
>> tests pass on 1.1 and 2.0 profiles(woho!). Please say whether it's
>> okay to commit and if the fixes should be backported.
> The previous patch did not handle indexed properties. Attached is an
> updated patch. I did a clean rebuild with the patch applied - no
> breakages. All Attributes tests pass.
> Zoltan, what do you think?
Since this affects reflection, one good testcase is that it doesn't
break the compiler. Can you check that this doesn't break
(you need to run this from the mono/ tree).
More information about the Mono-devel-list