[Mono-dev] [PATCH] corlib GetCustomAttributes for overriden properties bug

[Ivan N. Zlatev]

On Mon, Feb 25, 2008 at 9:43 PM, Ivan N. Zlatev <contact at i-nz.net> wrote:
> Please review the attached patch that fixes our behavior to match MS's
>  in terms of GetCustomAttributes for overridden attributes on
>  properties. That is:
>   * PropertyInfo.GetCustomAttributes - Inherit parameter is ignored and
>  behavior defaults to false
>   * Attributes.GetCustomAttributes - Inherit parameter is not ignored
>   * Attributes.IsDefined - Inherit parameter is not ignored on the 2.0 profile.
>
>  This patch fixes bugs #324472 and #322464. Also now all our Attribute
>  tests pass on 1.1 and 2.0 profiles(woho!). Please say whether it's
>  okay to commit and if the fixes should be backported.
>

The previous patch did not handle indexed properties. Attached is an
updated patch. I did a clean rebuild with the patch applied - no
breakages. All Attributes tests pass.

Zoltan, what do you think?

Cheers.
-- 
Ivan N. Zlatev

Web: http://www.i-nZ.net
"It's all some kind of whacked out conspiracy."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: attributes-bug-324472-322464.patch
Type: text/x-patch
Size: 7926 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20080226/19beb99b/attachment.bin