[Mono-dev] [PATCH] XmlSchemeExporter for typed DataTable

[Arina Itkes]

Ok. I moved the test to System.Data.

Please explain your claim about coding style. I didn't understand.

Arina.

-----Original Message-----
From: mono-devel-list-bounces at lists.ximian.com
[mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf Of Atsushi
Eno
Sent: Tuesday, January 29, 2008 8:09 PM
To: mono-devel-list at lists.ximian.com
Subject: Re: [Mono-dev] [PATCH] XmlSchemeExporter for typed DataTable

Hello,

You cannot add reference to System.Data.dll when building
System.Xml. Add your DataSet related test under System.Data.

The fix itself looks ok, except for coding style. I don't think
it was your first contribution though ...?
http://www.mono-project.com/Coding_Guidelines

Atsushi Eno


Arina Itkes wrote:
> 
> 
> Hi
> 
>  
> 
> I added a new test for exporting of a typed DataTable and a typed 
> DataSet by the same XmlSchemaExporter and a fix for the
XmlSchemaExporter.
> 
>  
> 
> Generated typed DataTable and typed DataSet have an identical schema
and 
> an identical TargetNamespace. This fix is a workaround for this
specific 
> case.
> 
>  
> 
> Please review.
> 
> Thanks.
> 
>  
> 
> 
>
------------------------------------------------------------------------
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list

_______________________________________________
Mono-devel-list mailing list
Mono-devel-list at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list