[Mono-dev] [PATCH] Bugs in StaticSiteMapProvider.cs

Juraj Skripsky js at hotfeet.ch
Thu Oct 18 04:23:46 EDT 2007


Hi Marek,

All tests were ok. Committed with Dictionaries instead of Hashtables and
a few more cleanups.

- Juraj



On Wed, 2007-10-17 at 11:42 +0200, Marek Habersack wrote:
> On Wed, 17 Oct 2007 11:18:21 +0200, Juraj Skripsky <js at hotfeet.ch> scribbled:
> 
> > Hi Marek,
> Hey Juraj,
> 
> > The attached patch fixes a few issues with StaticSiteMapProvider:
> > 
> > - AddNode doesn't check for key dups before adding items to hashtables
> > - RemoveNode doesn't remove item from keyToNode
> > - full urls (e.g. http://www.google.com) are not supported
> > 
> > And it cleans up a few dirty spots.
> > May I commit?
> Can you use the generic Dictionary instead of Hashtable? it will make the code
> faster. Otherwise, if no tests fail - do commit. Thanks!
> 
> regards,
> 
> marek




More information about the Mono-devel-list mailing list