[Mono-dev] [PATCH] Bugs in StaticSiteMapProvider.cs

Marek Habersack grendello at gmail.com
Wed Oct 17 05:42:09 EDT 2007


On Wed, 17 Oct 2007 11:18:21 +0200, Juraj Skripsky <js at hotfeet.ch> scribbled:

> Hi Marek,
Hey Juraj,

> The attached patch fixes a few issues with StaticSiteMapProvider:
> 
> - AddNode doesn't check for key dups before adding items to hashtables
> - RemoveNode doesn't remove item from keyToNode
> - full urls (e.g. http://www.google.com) are not supported
> 
> And it cleans up a few dirty spots.
> May I commit?
Can you use the generic Dictionary instead of Hashtable? it will make the code
faster. Otherwise, if no tests fail - do commit. Thanks!

regards,

marek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20071017/41e02b39/attachment.bin 


More information about the Mono-devel-list mailing list