[Mono-dev] [PATCH] Mono.Data.SqlExpressions improvements

[Joel Reed]

On Wed, Oct 03, 2007 at 09:29:48AM -0600, A Nagappan wrote:
> Hi,
> 
> Guess this patch is already checked in ?

Yes. Any concerns?

Btw, if there are any guidelines like: "wait X number of days"
before committing a posted patch I'll happily follow them.  

Thanks,

jr

> 
> Thanks
> Nagappan
> 
> --
> Nagappan A <anagappan at novell.com>
> Linux Desktop Testing Project - http://ldtp.freedesktop.org
> http://nagappanal.blogspot.com
> 
> Novell, Inc.
> SUSE® Linux Enterprise 10
> Your Linux is ready™
> http://www.novell.com/linux
> 
> 
> 
> >>> Joel Reed <joelwreed at gmail.com> 10/01/07 8:11 AM >>>
> I've done a bit more hacking on System.Data - Mono.Data.SqlExpressions 
> in order to fix a previously reported issue with IIF:
> 
> http://www.nabble.com/IIF-Bug-in-Mono.Data.SqlExpressions-Parser.jay-t4513001.html
> 
> The attached patch adds 3 new testcases and fixes the following bugs:
> 
> # IIF: Accept SingleColumnValues and Literals for condition
> # SUBSTRING: Accept arithmetic expressions for start, and length
> parameters
> # Removed last shift/reduce conflict
> # Fix obvious bug in "ArithExpr NOT LIKE StringLiteral" rule
> 
> I'd like to apply this patch. Please let me know if you see any
> issues with it. 
> 
> jr