[Mono-dev] [PATCH]: Rewrite instruction list handling.

David Miller davem at davemloft.net
Thu Nov 15 07:15:58 EST 2007


From: Paolo Molaro <lupus at ximian.com>
Date: Thu, 15 Nov 2007 12:38:59 +0100

> On 11/12/07 David Miller wrote:
> > In fact, significant chunks special list handling code got removed.
> > And I am certain many other significant cleanups and simplifications
> > become possible after this patch goes in.
> 
> I agree with the general change, but it's better to just add
> a prev field in MonoInst. This way we don't need to change
> all the code in all the architectures and risk regressions
> (some of which can be subtle as with many low-level JIT changes).
> With the new field in MonoInst that change can be done much more
> incrementally and so it can also be incrementally tested.

I made sure there were no regressions on 3 platforms and implemented
all of the changes for the rest.

All it takes is someone able to test my patch on those remaining
platforms and about an hour of developer time to weed out any
regressions.

I disagree that adding a 'prev' field is the way to implement these
changes especially since I've done all the work already.

Take care.



More information about the Mono-devel-list mailing list