[Mono-dev] [Fwd: [Mono-patches] r77895 - trunk/mcs/class/System.XML/System.Xml.Serialization]

[Atsushi Eno]

Hi,
Are you sure what you are changing? If there is no assuring tests
than the feeling "it looks wrong", I will revert the change since
I'm not sure if this change has no side effect.

Thanks
Atsushi Eno

-------- Original Message --------
Subject: [Mono-patches] r77895 - 
trunk/mcs/class/System.XML/System.Xml.Serialization
Date: Thu, 24 May 2007 04:50:24 -0400 (EDT)
From: Konstantin Triger (kostat at mainsoft.com) 
<mono-patches-list at lists.ximian.com>
To: mono-patches at lists.ximian.com, ximian.monolist at gmail.com, 
mono-svn-patches-garchive-20758 at googlegroups.com

Author: kostat
Date: 2007-05-24 04:50:24 -0400 (Thu, 24 May 2007)
New Revision: 77895

Modified:
    trunk/mcs/class/System.XML/System.Xml.Serialization/ChangeLog
    trunk/mcs/class/System.XML/System.Xml.Serialization/TypeTranslator.cs
Log:
fix typo: set IsNullable flag for primitiveNullableTypes

Modified: trunk/mcs/class/System.XML/System.Xml.Serialization/ChangeLog
===================================================================
--- trunk/mcs/class/System.XML/System.Xml.Serialization/ChangeLog 
2007-05-24 08:14:45 UTC (rev 77894)
+++ trunk/mcs/class/System.XML/System.Xml.Serialization/ChangeLog 
2007-05-24 08:50:24 UTC (rev 77895)
@@ -1,3 +1,7 @@
+2007-05-24  Konstantin Triger <kostat at mainsoft.com>
+
+	* TypeTranslator.cs: fix typo: set IsNullable flag for 
primitiveNullableTypes.
+
  2007-05-14  Adar Wesley <adarw at mainsoft.com>

  	* XmlSchemaExporter.cs: added missing overload for method ExportAnyType.

Modified: 
trunk/mcs/class/System.XML/System.Xml.Serialization/TypeTranslator.cs
===================================================================
--- 
trunk/mcs/class/System.XML/System.Xml.Serialization/TypeTranslator.cs 
2007-05-24 08:14:45 UTC (rev 77894)
+++ 
trunk/mcs/class/System.XML/System.Xml.Serialization/TypeTranslator.cs 
2007-05-24 08:50:24 UTC (rev 77895)
@@ -136,7 +136,7 @@
  			primitiveTypes.Add ("base64", new TypeData (typeof (byte[]), 
"base64", true));

  #if NET_2_0
-			primitiveNullableTypes = new Hashtable ();
+			primitiveNullableTypes = Hashtable.Synchronized(new Hashtable ());
  			foreach (DictionaryEntry de in primitiveTypes) {
  				TypeData td = (TypeData) de.Value;
  				TypeData ntd = new TypeData (td.Type, td.XmlType, true);
@@ -163,14 +163,13 @@

  				TypeData pt = GetTypeData (type); // beware this recursive call 
btw ...
  				if (pt != null) {
-					lock (primitiveNullableTypes) {
  						TypeData tt = (TypeData) primitiveNullableTypes [pt.XmlType];
  						if (tt == null) {
  							tt = new TypeData (type, pt.XmlType, true);
+							tt.IsNullable = true;
  							primitiveNullableTypes [pt.XmlType] = tt;
  						}
  						return tt;
-					}
  				}
  			}
  #endif

_______________________________________________
Mono-patches maillist  -  Mono-patches at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-patches