[Mono-dev] Will fix and resubmitt Re: Patch for Math.cs and MathTest.cs

[Dennis Hayes]

I should have checked on that.
  I will just modify the error to a simple string i.e. 
  throw new ArgumentException (Locale.GetText ("This mode is not valid value for MidpointRounding."), "mode")
  I will verify the changes are made everywhere and resubmit again.
  Thanks for taking the time to check the patch.
  Dennis


Andreas Nahr <ClassDevelopment at A-SoftTech.com> wrote:        Locale.GetText ("The value '" + mode + "' is not valid for this usage of the type MidpointRounding.")
  That is not going to work, because you would have to localize every possible concatenated string combination. Moreover tools wouldn't be able to extract the neccessary string data.
  If there is no problem with recursive calls you can use String.Format.
  Greetings
  Andreas


    
---------------------------------
  Von: mono-devel-list-bounces at lists.ximian.com [mailto:mono-devel-list-bounces at lists.ximian.com] Im Auftrag von Dennis Hayes
Gesendet: Donnerstag, 15. März 2007 22:55
An: mono-devel-list at lists.ximian.com
Betreff: [Mono-dev] Patch for Math.cs and MathTest.cs


  
    Math.cs
      Added Locale.GetText to all strings.
      Rearranged Rounding with MidPoint to minimize compairs, and to clean up a bit.
   
  MathTest.cs
      Added quite a few new tests for rounding, including test for
      the 2.0 rounding with midpoint.
      It also incudes new test for veryfing bad enum execptions.
   
      6 of the test are commented out because they fail.
      3 fail because they have not been implmented.
      1 fails due to a know rounding error already in bugzilla (new
      test to exercise bug 60227 & 63902 should return 3.45, not 3.45000000000...
  
       2 fail for what looks like a different error. 
  //fails. Should return 2.6, but actualy returns 2.5
  //AssertEquals("Decmial Rounding toEven", 2.6D , Math.Round(2.55D, 1));
  Bug 60227 covers a number of rounding errors, it was not clear of it included this one or not.
   
  If these are good, please check them it. Otherwise let me know what is wrong.
   
  Thanks,
  Dennis

    
---------------------------------
  No need to miss a message. Get email on-the-go 
with Yahoo! Mail for Mobile. Get started. 

 
---------------------------------
8:00? 8:25? 8:40?  Find a flick in no time
 with theYahoo! Search movie showtime shortcut.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070316/915c8786/attachment.html