[Mono-dev] [Patch] fix for #82022

Rodrigo Kumpera kumpera at gmail.com
Tue Jul 10 09:17:26 EDT 2007

Hi Paolo,

Shouldn't the other case that returns NULL in mono_class_create_from_typedef
use mono_class_set_failure as well? From now on I'll send patches using
.diff extension.

Thanks for the review!

On 7/9/07, Paolo Molaro <lupus at ximian.com> wrote:
> On 07/06/07 Rodrigo Kumpera wrote:
> > The attached patch fixes #82022. The fix is quite simple, it just checks
> if
> > the enum field is null and abort the loading process. But there are two
> > issues with this patch, first it could return a more informative message
> > about the problem and I'm not sure if it won't leak memory or cause
> future
> > problems.
> Yes, this will cause a leak. Use mono_class_set_failure() to make
> sure the runtime considers the type as faulty and return it.
> BTW, if you name your patch files as name.diff gmail will properly
> attach them as text files instead of binary blobs making the review
> easier.
> Thanks!
> lupus
> --
> -----------------------------------------------------------------
> lupus at debian.org                                     debian/rules
> lupus at ximian.com                             Monkeys do it better
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070710/d21712a7/attachment.html 

More information about the Mono-devel-list mailing list