[Mono-dev] [Patch] fix for #82022

Paolo Molaro lupus at ximian.com
Mon Jul 9 05:57:51 EDT 2007


On 07/06/07 Rodrigo Kumpera wrote:
> The attached patch fixes #82022. The fix is quite simple, it just checks if
> the enum field is null and abort the loading process. But there are two
> issues with this patch, first it could return a more informative message
> about the problem and I'm not sure if it won't leak memory or cause future
> problems.

Yes, this will cause a leak. Use mono_class_set_failure() to make
sure the runtime considers the type as faulty and return it.

BTW, if you name your patch files as name.diff gmail will properly
attach them as text files instead of binary blobs making the review
easier.
Thanks!

lupus

-- 
-----------------------------------------------------------------
lupus at debian.org                                     debian/rules
lupus at ximian.com                             Monkeys do it better



More information about the Mono-devel-list mailing list