[Mono-dev] [PATCH] Add VBC_VER and TARGET conditional constants and fix string comparsion

Rolf Bjarne Kvinge rolflists at ya.com
Tue Feb 27 03:35:31 EST 2007



> -----Original Message-----
> From: Kornél Pál [mailto:kornelpal at gmail.com]
> Sent: martes, 27 de febrero de 2007 1:36
> To: Rolf Bjarne Kvinge
> Cc: mono-devel-list at lists.ximian.com
> Subject: [PATCH] Add VBC_VER and TARGET conditional constants and fix
> string comparsion
> 
> Hi,
> 
> See http://msdn2.microsoft.com/en-us/library/swfss70d(VS.80).aspx
> 
> Note that TARGET is undefined when it is defined on command line that
> is weird.
> 
> Also note that string comparsion is currently inverse (negated that is
> a
> bug) and case insensitive but should be binary comparsion without any
> regard to characters.
> 
> Please review and approve the patch.
> 
> Kornél

The patch is ok, but please add a couple of tests for it.

Rolf




More information about the Mono-devel-list mailing list