[Mono-dev] Patch to fix #ifdef in VS build

Jonathan Chambers joncham at gmail.com
Mon Feb 19 07:01:01 EST 2007


Sure, I'll change to PLATFORM_WIN32 (to be consistent with the rest of mono)
and commit if there are no other issues.

Thanks,
Jonathan

On 2/19/07, Robert Jordan <robertj at gmx.net> wrote:
>
> Jonathan Chambers wrote:
> > The #ifdef for the dummy_apc function in threads.c is incorrect for VS.
> I
> > think Robert Jordan found this a while ago, but it never got patched. I
> > 'refound' the problem after a few hours so I'd like to get this in this
> > time.
>
> Oops, I forgot to commit this, sorry :-/
>
> > -#ifdef __MINGW32__
> > -static CALLBACK void dummy_apc (ULONG_PTR param)
> > +#if  defined (__MINGW32__) || defined (_MSC_VER)
> > +static void CALLBACK dummy_apc (ULONG_PTR param)
>
> Since this is a platform feature, I'd rather use #ifdef PLATFORM_WIN32.
>
> Robert
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20070219/b73a68ca/attachment.html 


More information about the Mono-devel-list mailing list