[Mono-dev] XmlTextReader.cs patch (IBM bug workaround)

[Atsushi Eno]

Since we will *never* take care of this IBM bugs in the future fixes,
you had better just checkin XmlTextReader.jvm.cs to keep yourselves
paying attention to have it in sync with the latest fixes. Asking
others to pay attention to this kind of "this" dependency and avoid
the issue is inappropriate.

It should be really easy by having a diff inside the sources (you
can checkin such a diff in the sources).

Atsushi Eno

Eyal Alaluf wrote:
> Hi, Miguel.
> 
> We tested the patch on the attached testcase and saw a degradation of
> ~1%.
> The results were:
>    Before the change (ticks, 2 runs):
>        1478000000
>        1475510000
>    After the change:
>        1486280000
>        1485810000
> Clearly Mono doesn't inline this change but on the other hand the impact
> is not significant in the tested scenario.
> As for the IBM bug we have a Java test case and the minimal scenario we
> see is tricky enough to believe that it will happen rarely.
> Do you think it is reasonable to commit the patch despite the slight
> degradation in performance?
> 
> Eyal.
> 
> -----Original Message-----
> From: mono-devel-list-bounces at lists.ximian.com
> [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf Of Miguel de
> Icaza
> Sent: 18 April 2007 15:10
> To: Sasha Kogan
> Cc: mono-devel-list at lists.ximian.com
> Subject: Re: [Mono-dev] XmlTextReader.cs patch (IBM bug workaround)
> 
> Hello Sasha,
> 
>> Alternativelly, we could wrap the patch in "#if TARGET_JVM", but since
>> there're numerous places in the code where it should be applied, this
>> approach would dirty the code too much. 
> 
> We need to review if this will have a performance impact on Mono (see if
> Mono is able to inline this).
> 
> Miguel
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list