[Mono-dev] [PATCH] System.Security: Remove "hack" from KeyInfoX509Data

[Sebastien Pouliot]

Hello Gert,

On Mon, 2006-09-25 at 23:11 +0200, Gert Driesen wrote:
> Hi,
> 
> The attached patch removed an (unnecessary) hack from KeyInfoX509Data.

I doubt it was added, with such a specific comment, without reasons.

> The hack added an explicit declaration of the XMLDSIG namespace. This was
> supposedly for compatibility with MS, but I tested with .NET 1.0, .NET 1.1
> and .NET 2.0 and none of these emit that extra namespace declaration or rely
> on it.
> 
> All unit tests and standalone tests pass after removing this hack.

Maybe something else changed to make this un-required.
Maybe the test suite doesn't cover this case.

> Let me know if it's ok to commit.

No. First, it was put there for a reason(*) and second you aren't saying
why it should be removed(**) beside being unrequired (which it was not
at some point).

(*) try to track down when (svn blame) and why (ChangeLog entry) this
was added. It may explain if (or refer to why) it's still required or
not.

(**) if having this extra line is breaking something then please add a
test case to the unit tests.

-- 
Sebastien Pouliot  <sebastien at ximian.com>
Blog: http://pages.infinit.net/ctech/