[Mono-dev] ChangeLog entries (was Re: [PATCH] System.Security: Remove "hack" from KeyInfoX509Data)

[Raja R Harinath]

Hi,

"Gert Driesen" <gert.driesen at telenet.be> writes:
[snip]
> Index: KeyInfoX509Data.cs
> ===================================================================
> --- KeyInfoX509Data.cs	(revision 65793)
> +++ KeyInfoX509Data.cs	(working copy)
> @@ -195,8 +195,6 @@
>  #endif
>  			XmlDocument document = new XmlDocument ();
>  			XmlElement xel = document.CreateElement (XmlSignature.ElementNames.X509Data, XmlSignature.NamespaceURI);
> -			// FIXME: hack to match MS implementation
> -			xel.SetAttribute ("xmlns", XmlSignature.NamespaceURI);
>  			// <X509IssuerSerial>
>  			if ((IssuerSerialList != null) && (IssuerSerialList.Count > 0)) {
>  				foreach (X509IssuerSerial iser in IssuerSerialList) {
>
> Property changes on: KeyInfoX509Data.cs
> ___________________________________________________________________
> Name: svn:eol-style
>    + native
>
> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 65793)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,8 @@
> +2006-09-25  Gert Driesen  <drieseng at users.sourceforge.net>
> +
> +	* KeyInfoX509Data.cs: Removed hack which resulted in unnecessary
> +	namespace declaration. Set eol-style to native.
> +

On a style note, I think it's better _not_ to put repository metadata
maintenance information into the ChangeLog.  It's not really germane to
an offline user.

- Hari