[Mono-dev] Fwd: Tests for System.Data.OracleClient

[Konstantin Triger]

Hello,

Our build is upgraded to C# 2 and we worked on removing JVM defines needed only for C# 1.1 compatibility. If you see such a define, please let us know to remove it.

Regards,
Konstantin Triger

-----Original Message-----
From: Miguel de Icaza [mailto:miguel at ximian.com] 
Sent: Tuesday, October 17, 2006 4:11 PM
To: Leszek Ciesielski
Cc: Konstantin Triger; mono-devel-list at lists.ximian.com; Noam Lampert
Subject: Re: [Mono-dev] Fwd: Tests for System.Data.OracleClient

Hey,

> Could you explain to me why sometimes JVM specific code is included
> through TARGET_JVM and sometimes it is placed in separate files? In
> OracleClient this seems to cause some functionality to work only in
> JVM, while sharing the code would bring fixes to other profiles. Would
> such a merge be possible? And if yes, what would be the caveats?

If the changes are small, compared to the overall file, we use the
define.  If they are large, we use the separate file.

We could use partial classes, but it depends on whether Mainsoft has
already upgraded their build setup to C# 2, and that would help clean up
a *lot* of the JVM defines.