[Mono-dev] System.dll few patches for review

Sebastien Pouliot sebastien.pouliot at gmail.com
Tue Oct 3 10:09:38 EDT 2006

Hello Andrew,

On Tue, 2006-10-03 at 06:40 -0700, Andrew Skiba wrote:
> Hello.
> Please review these patches for System.dll.
> Part of them is needed to omit TARGET_JVM, so code will be common.

There are no TARGET_JVM in the two files.

> * DigestClient.patch - use MD5.Create instead of HashAlgorithm.Create
> ("MD5")

This is ok in the sense that it will result in the exact same thing. So
the question is: Is that change required ? if so, can you say why (and
include the rational in the ChangeLog).

> * X509CertificateCollection.patch - remove unnecessary overload

If this doesn't cause any error with the class library status pages then
remove (don't comment) it. The comment itself can be put in the

Sebastien Pouliot  <sebastien at ximian.com>
Blog: http://pages.infinit.net/ctech/

More information about the Mono-devel-list mailing list