[Mono-dev] [PATCH] implement support for auto:LANGID culture specifications in ASP.NET 2.0 globalization

[Marek Habersack]

On Mon, 20 Nov 2006 17:36:35 +0530, Raja R Harinath
<rharinath at novell.com> scribbled:

> Hi,
hey :)

[snip]
> >  
> >  			if (appui_culture != null) {
> >  				prev_appui_culture =
> > th.CurrentUICulture; +#if NET_2_0
> > +				th.CurrentUICulture =
> > GetThreadCulture (Request, appui_culture, autoUICulture); +#else
> >  				th.CurrentUICulture =
> > appui_culture; +#endif
> >  			}
> 
> And just use the first variant.  We don't want unnecessary '#if's
> sprinkled around the code since it increases the number of code paths
> that need to examined.
I did it for space purposes - just thought there wasn't any need to add
more size (even if it's not much) to the 1.x assembly. Also, calling
the method in 1.x seemed like a waste of time needed to do the call. But
if it's fine, then I'll be more than glad to remove the ifdefs :)

Please review the attached diff, best regards

marek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: globalization.diff
Type: text/x-patch
Size: 7582 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20061120/4d7ebf4b/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20061120/4d7ebf4b/attachment-0001.bin