[Mono-dev] [PATCH] Boost speed of UnicodeEncoding

[Kornél Pál]

Hi,

When I submitted my previous patch I followed the coding style of the
existing code. Then you asked me to follow the coding guidelines (actually
only three of them but I thought you mean all of them). And I think that a
code with half this and half that stlye looks ugly so I modified the entire
coding style.

Now I resend the same patch with only the three style changes you requested
applied only to modified lines. This will eliminate unmodified but 
reformatted lines from the patch but I think mixed coding style looks ugly. 
If you still don't like the coding style
please feel free to reformat it but I'm not going to reformat the code 
again.

Of course I send the patch for review so if you find bugs please let me
know.

Kornél

----- Original Message ----- 
From: "Atsushi Eno" <atsushi at ximian.com>
To: "Kornél Pál" <kornelpal at gmail.com>
Cc: <mono-devel-list at lists.ximian.com>
Sent: Monday, March 20, 2006 3:04 AM
Subject: Re: [Mono-dev] [PATCH] Boost speed of UnicodeEncoding


> Hi,
>
> Kornél Pál wrote:
>> I already sent this to the list but I didn't receive it. Now I changed to
>> GMail so now everything should be better.:)
>>
>>> Cool, thanks Kornél. Can you please commit the patch with a few
>>> coding style fixes?
>>>
>>> foo [i] instead of foo[i]
>>> Blah () instead of Blah()
>>> (byte) x instead of (byte)x
>>
>> As previously I followed the style of existing code I modified the style
>> of
>> the entire code. In addition I moved UnicodeDecoder to the top of
>> UnicodeEncoding to have a more common style.
>>
>> Previously I forgot to update UnicodeDecoder.GetChars but now it is
>> updated
>> as well.
>>
>> Lupus pointed out the problem with zero-length arrays so now it is fixed
>> as
>> well.
>>
>> Please have another look at the patch. Now I consider it to be complete.
>>
>> Kornél
>
> Please don't mix different kind of changes: indentation and actual
> code fixes. The new patch is not reviewable. The previous one is better.
>
> Atsushi Eno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: UnicodeEncoding.diff
Type: application/octet-stream
Size: 13816 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060320/ece4f6d7/attachment.obj