[Mono-dev] System warning removal.

Miguel de Icaza miguel at novell.com
Sat Mar 11 12:55:56 EST 2006


Hello,

> +		// Invoked from System.Web, disable warning
> +#pragma warning disable 169
>  		static IConfigurationSystem ChangeConfigurationSystem (IConfigurationSystem newSystem)
>  		{
> 
> 
> I think to make the method internal is more common practice.

Great trick.

> +#pragma warning disable 67
>  		public event SerialErrorReceivedEventHandler ErrorReceived;
>  		public event SerialPinChangedEventHandler PinChanged;
>  		public event SerialDataReceivedEventHandler DataReceived;
> +#pragma warning restore
> 
> 
> I would prefer #if false because these events are MonoTODO indeed.

Well, they are part of the public API, so we should not remove them.

Miguel.



More information about the Mono-devel-list mailing list