[Mono-dev] [Patch] Some bugs in xbuild and DirectorySeparator.

Marek Sieradzki marek.sieradzki at gmail.com
Sat Mar 11 05:47:24 EST 2006

Dnia 11-03-2006, sob o godzinie 07:56 +0200, Crestez Leonard napisał(a):
> I fixed some bugs in xbuild.
> First, there's no reason for BuildItem.GetMetadata to always fail when
> the file doesn't exist, msbuild doesn't do that. Stuff that only relies
> on the path should work.
> I also modified DirectoryScanner a lot. It used to reorder multiple
> includes and fail on duplicates. msbuild doesn't do either.

I didn't know that it failed on duplicates and forgot to place FIXME for
reordering (caused by hashtable).
> The patch is from a svn diff in the root mcs dir.
> Right now xbuild won't work with msbuild projects because of path
> separator problems. A patch to make xbuild take both / and \ as path
> separators should be easy to write, but it's ugly. On the other hand
> current behaviour makes xbuild useless. Will you accept the patch if I
> write it?

Yes. I wondered what should I do about strings like "a\b". Should I
search for '\' and replace with '/' or make switch to xbuild.exe or what

BTW there are way more reasons why xbuild won't run VS2005 project
> Also, I noticed that in mono both Path.DirectorySeparatorChar and
> Path.AltDirectorySeparatorChar are /, while msdn says on unix they
> should be / and \. I know monodoc says they're both /, but why?

I'm really excited of that someone tried to fix this mess. Also it would
be great not to duplicate work. I'm synchronizing my local changes with
SVN today.

Could you send the patch?

Marek Sieradzki <marek.sieradzki at gmail.com>

More information about the Mono-devel-list mailing list