[Mono-dev] [Fwd: [Mono-patches] r56597- trunk/mcs/class/System.XML/Test/System.Xml.Schema]

[Atsushi Eno]

Hi,

>> Please revert this patch which is done without any agreement.
> 
> I know, but I thought it was a very trivial patch.

Well, my bad, agreement part does not that matter (usually
I am regarded as to have agreed to commit such patches just
because I am the maintainer, so I put status for some patches
as a disclaimer). If you'll take future responsibilities from
the change then it is no problem though.

>> There is a reason I marked it as NotWorking - it is for
>> compatibility kids. 
> 
> Why mark something "NotWorking" if it is indeed working ?

Umm, you are right on the different aspect. It should be
indeed [Ignore] since the test itself is wrong, as well as
our code is not correct (in compatibility aspect).

NotDotNet should be used only in such case that 1)MS has buggy
implementation, or 2)the test is Mono dependent, or so.

>> I am not likely to fix this trivial stuff
>> soon, but someone might notice the impl. difference from it.
>> Marking NotDotNet is clearly wrong: we do not test and complain
>> if mono fails to assert this behavior.
>>
>> (Leaving Assertion->Assert changes is OK.)
>>
>> Actually why did you mark it as NotDotNet? It does not fail under
>> .NET 2.0 (or do you have different .NET 2.0 than mine, 2.0.50727 ?)
> 
> On my systems, it only failed on .NET 2.0 (but worked fine on Mono 1.0/2.0
> and MS.NET 1.x).

OK, your change on #4 was wrong: it changes AssertNull() to 
Assert.Is*Not*Null() which obviously changes test semantics.

I'll revert the change and remark it as Ignore. No need to waste
extra time.

Atsushi Eno