[Mono-dev] [Fwd: [Mono-patches] r56597 - trunk/mcs/class/System.XML/Test/System.Xml.Schema]

[Atsushi Eno]

Gert,

Please revert this patch which is done without any agreement.
There is a reason I marked it as NotWorking - it is for
compatibility kids. I am not likely to fix this trivial stuff
soon, but someone might notice the impl. difference from it.
Marking NotDotNet is clearly wrong: we do not test and complain
if mono fails to assert this behavior.

(Leaving Assertion->Assert changes is OK.)

Actually why did you mark it as NotDotNet? It does not fail under
.NET 2.0 (or do you have different .NET 2.0 than mine, 2.0.50727 ?)

Thanks,
Atsushi Eno

-------- Original Message --------
Subject: [Mono-patches] r56597 - 
trunk/mcs/class/System.XML/Test/System.Xml.Schema
Date: Mon,  6 Feb 2006 16:13:15 -0500 (EST)
From: Gert Driesen (gert.driesen at pandora.be) 
<mono-patches-list at lists.ximian.com>
To: mono-patches at lists.ximian.com, ximian.monolist at gmail.com, 
mono-patches-list at googlegroups.com

Author: gert
Date: 2006-02-06 16:13:15 -0500 (Mon, 06 Feb 2006)
New Revision: 56597

Modified:
    trunk/mcs/class/System.XML/Test/System.Xml.Schema/ChangeLog
 
trunk/mcs/class/System.XML/Test/System.Xml.Schema/XmlSchemaDatatypeTests.cs
Log:
* XmlSchemaDatatypeTests.cs: Marked TestAnyType NotDotNet on 2.0 profile
instead of marking it NotWorking. No longer derive from Assertion.


Modified: trunk/mcs/class/System.XML/Test/System.Xml.Schema/ChangeLog
===================================================================
--- trunk/mcs/class/System.XML/Test/System.Xml.Schema/ChangeLog 
2006-02-06 21:01:47 UTC (rev 56596)
+++ trunk/mcs/class/System.XML/Test/System.Xml.Schema/ChangeLog 
2006-02-06 21:13:15 UTC (rev 56597)
@@ -1,3 +1,9 @@
+2006-02-06  Gert Driesen <drieseng at users.sourceforge.net>
+
+	* XmlSchemaDatatypeTests.cs: Marked TestAnyType NotDotNet on 2.0
+	profile instead of marking it NotWorking. No longer derive from
+	Assertion.
+
  2006-02-01  Atsushi Enomoto <atsushi at ximian.com>

  	* XmlSchemaDatatypeTests.cs : added two more anyURI tests.

Modified: 
trunk/mcs/class/System.XML/Test/System.Xml.Schema/XmlSchemaDatatypeTests.cs
===================================================================
--- 
trunk/mcs/class/System.XML/Test/System.Xml.Schema/XmlSchemaDatatypeTests.cs 
2006-02-06 21:01:47 UTC (rev 56596)
+++ 
trunk/mcs/class/System.XML/Test/System.Xml.Schema/XmlSchemaDatatypeTests.cs 
2006-02-06 21:13:15 UTC (rev 56597)
@@ -24,7 +24,7 @@
  namespace MonoTests.System.Xml
  {
  	[TestFixture]
-	public class XmlSchemaDatatypeTests : Assertion
+	public class XmlSchemaDatatypeTests
  	{
  		private XmlSchema GetSchema (string path)
  		{
@@ -41,25 +41,26 @@
  		{
  			XmlSchemaElement element = schema.Items [index] as XmlSchemaElement;
  			XmlSchemaDatatype dataType = element.ElementType as XmlSchemaDatatype;
-			AssertEquals (tokenizedType, dataType.TokenizedType);
-			AssertEquals (type, dataType.ValueType);
-			AssertEquals (parsedValue, dataType.ParseValue (rawValue, null, null));
+			Assert.AreEqual (tokenizedType, dataType.TokenizedType, "#1");
+			Assert.AreEqual (type, dataType.ValueType, "#2");
+			Assert.AreEqual (parsedValue, dataType.ParseValue (rawValue, null, 
null), "#3");
  		}

  		[Test]
-		[Category ("NotWorking")] // ContentTypeParticle impl. difference.
+#if NET_2_0
+		[Category ("NotDotNet")] // BaseSchemaType impl. difference.
+#endif
  		public void TestAnyType ()
  		{
  			XmlSchema schema = GetSchema ("Test/XmlFiles/xsd/datatypesTest.xsd");
  			schema.Compile (null);
  			XmlSchemaElement any = schema.Elements [QName ("e00", "urn:bar")] 
as XmlSchemaElement;
  			XmlSchemaComplexType cType = any.ElementType as XmlSchemaComplexType;
-			AssertEquals (typeof (XmlSchemaComplexType), cType.GetType ());
-			AssertNotNull (cType);
-			AssertEquals (XmlQualifiedName.Empty, cType.QualifiedName);
-			AssertNull (cType.BaseSchemaType);
-			// In MS.NET its type is "XmlSchemaParticle.EmptyParticle"
-			AssertNotNull (cType.ContentTypeParticle);
+			Assert.AreEqual (typeof (XmlSchemaComplexType), cType.GetType (), "#1");
+			Assert.IsNotNull (cType, "#2");
+			Assert.AreEqual (XmlQualifiedName.Empty, cType.QualifiedName, "#3");
+			Assert.IsNotNull (cType.BaseSchemaType, "#4");  // In MS.NET 2.0 its 
null
+			Assert.IsNotNull (cType.ContentTypeParticle, "#5");
  		}

  		[Test]

_______________________________________________
Mono-patches maillist  -  Mono-patches at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-patches