[Mono-dev] Another COM Interop Patch

[Jon Chambers]

Slightly modified patch. I did make MonoType.IsCOMObjectImpl an internal
call. Also, I fixed a problem with calling the constructor of RCWs (both
order, and the fact that I was always calling the default/empty .ctor). As
indicated in ChangeLog, all contributions are under the MIT/X11 license.

- Jonathan

On 8/9/06, Zoltan Varga <vargaz at gmail.com> wrote:
>
> Hi,
>
> This is ok to check in.
>
>    Zoltan
>
> On 8/9/06, Jon Chambers <joncham at gmail.com> wrote:
> > Here is another patch for COM Interop.
> >
> > 1. Corrected marshalling when MarshalAs is specified as IDispatch or
> > IUnknown.
> > 2. Added null checks to marshalling code
> > 3. Added is_com_object field to classes. This is required because it is
> > possible to derive from a ComImport attributed type. Thus the current
> type
> > where the method is defined is not marked with the attribute, but a
> > supertype is.
> > 4. Added tests and fixed QueryInterface implementation so that test runs
> > successfully on .Net.
> > 5. Fixed cominterop_get_com_slot_for_method to look on
> > interface where method is defined, not on implementing class, for
> > attributes.
> >
> > The only minor thing is whether I should have IsCOMObjectImpl be an
> internal
> > call and simply check the is_com_object flag of the class? This seems to
> > make sense, but not sure whether I should add an internal call if I can
> do
> > it in managed (albeit less efficiently).
> >
> > Thanks,
> > Jonathan
> >
> > _______________________________________________
> > Mono-devel-list mailing list
> > Mono-devel-list at lists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/mono-devel-list
> >
> >
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060810/fc297be5/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cominterop.diff
Type: text/x-patch
Size: 23334 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060810/fc297be5/attachment.bin