[Mono-dev] [PATCH] Add default code page to build system

[Kornél Pál]

This was a reply to your comments on the patch. The patch is in the original
message. Note that my previos message a second reply as you simply ignored
the first one so last time I tried to include only relevant information.

I included a diff file based on the latest SVN revision for your
convenience.

The patch in not critical so can go in after 1.1.9 but I would like to get
some feedback. Is it OK to commit? Should something be changed?

Messages in this thread:

Original message including the patch:
http://lists.ximian.com/pipermail/mono-devel-list/2005-August/014359.html
Your reply:
http://lists.ximian.com/pipermail/mono-devel-list/2005-August/014369.html
My first reply:
http://lists.ximian.com/pipermail/mono-devel-list/2005-August/014382.html
My second reply:
http://lists.ximian.com/pipermail/mono-devel-list/2005-September/014535.html
Your previous reply:
http://lists.ximian.com/pipermail/mono-devel-list/2005-September/014540.html

Kornél

----- Original Message -----
From: "Miguel de Icaza" <miguel at ximian.com>
To: "Kornél Pál" <kornelpal at hotmail.com>
Cc: <mono-devel-list at lists.ximian.com>
Sent: Tuesday, September 06, 2005 3:07 PM
Subject: Re: [Mono-dev] [PATCH] Add default code page to build system


> Hello,
>
>> Our compiler, mcs uses ISO-28591 as the default code page. This means
>> that
>> the whole class library is compiled using this code page and we seem to
>> use
>> this code page (ISO-28591) as it compiles. The only exception is
>> Microsoft.VisualBasic. It uses UTF-8 for a long time and it uses
>> /codepage:650001 in it's Makefile.
>>
>> The patch does not change the code page we use. Currently it's primary
>> goal
>> is that we should specify our default code page on mcs code page instead
>> of
>> in mcs source code that should use Encoding.Default as the default code
>> page. Specifying default code page on command line let us use csc.exe as
>> well on all systems at it defaults to Encoding.Default.
>>
>> Is the patch OK to commit or are there any other issues?
>
> You forgot to attach the patch.
>
> We are about to freeze the tree for the 1.1.9 release, so a  patch like
> this should not go in until after the release.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DefaultCodePage.diff
Type: application/octet-stream
Size: 3464 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050906/8b447b5f/attachment.obj