[Mono-dev] System.Colletions.Generic.SortedList
Ben Maurer
bmaurer at ximian.com
Fri Oct 28 22:53:56 EDT 2005
This is looking pretty good:
* Since the enumerator is private, can you use a `yield' based
one? that will be cleaner.
* The indentation is a bit funkey, please use tags
* When you do int pos = Array.IndexOf(this.sortedKeys, key); for
Contains, etc, you should use binary search, as it will be
faster
* It's cleaner to do if (blah) throw Exception; ... rather than if
(!blah) ...; else throw Exception ();
* IDictionary.Remove argument checking is incorrect
* Needs test cases
* (does msft use some sort of tree structure here? -- this is only
an initial impl, so it's not really necessary to be fully
optimal).
-- Ben
More information about the Mono-devel-list
mailing list