[Mono-dev] [PATCH] Warning and errors for InternalsVisibleAttr

Carlos Alberto Cortez calberto.cortez at gmail.com
Fri Oct 14 02:35:05 EDT 2005


Comments below:

El vie, 14-10-2005 a las 09:08 +0100, Marek Safar escribió:
> Hello,
> >The attached patch checks the validity of InternalsVisibleToAttribute,
> >and reports and warnings depending on the contents.
> >
> >May I commit?
> >  
> >
> - no test for CS1700.

Sorry, since it is a warning I didn't take the time for it. The test is

> - please use syntax `blabla' for error/warning arguments.


> +			if (a.Type == TypeManager.internals_visible_attr_type)
> +				if (!CheckInternalsVisibleAttribute (a))
> +					return;
> +			
> Please use, &&.


> But I am not sure whether we should commit this to mcs and then 
> integrate or to gmcs only.
> Any ideas ?

Well, I think we should keep it in gmcs only by now, since it requires
InternalsVisibleToAttribute, which is 2.0 only. 

I was trying to figure out a way to commit it to mcs, but they would be
hacks, so I would prefer to keep this in gmcs.

The patch with the changes is attached. Here it's 4 a.m, so I think I
will write the test tomorrow.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: internals-changes.diff
Type: text/x-patch
Size: 3388 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20051014/bfacf113/attachment.bin 

More information about the Mono-devel-list mailing list