[Mono-devel-list] Patch for System.Data.Common and System.Data.ProviderBase
Konstantin Triger
kostat at mainsoft.com
Tue May 24 08:57:24 EDT 2005
Just a word about "_" prefix.
When you review a patch, it's much easier to catch errors when there is
a clear difference between local variables and class fields.
For example if you have see something like that:
xxx = 6;
Don't you want to know exactly that the class state was not changed?
Regards,
Konstantin Triger
Sureshkumar T wrote:
>>I'll try to keep the code as close as possible to the guidelines.
>>
>>
>
>Thanks.
>
>
>
>>DbParameterBase.Parent : used by DbParameterCollectionBase to track
>>collection ownership on parameters (for example it should be impossible
>>to add the same parameter to two different collections simultaneously).
>>I choose to implement this through internal property rather that
>>internal variable.
>>
>>
>
>Ok.
>
>
>
>>Private variables naming : since code guide lines do no define this
>>well, I did the changes for the following reasons :
>>_paramValue -> _value and _name -> _parameterName : keep private member
>>name close to property name, so the code will be more readable.
>>
>>
>
>Ok, Understandable. But, name for a parameter is always parameter's
>name. anyway, if you feel it is necessary, change them.
>
>
>
>>adding _ to parameter names : to enable easy recognize of an errors like :
>>
>>int myProperty;
>>
>>public int MyProperty
>>{
>> get { return MyProperty; }
>>}
>>
>>
>
>here, anyway, we use CamelCase for properties and first-letter-small for
>private members. we could have got the error by seeing M in return
>statements.
>
>Please feel free to post the reworked patch.
>
>Thanks,
>suresh.
>_______________________________________________
>Mono-devel-list mailing list
>Mono-devel-list at lists.ximian.com
>http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
More information about the Mono-devel-list
mailing list