[Mono-devel-list] Patch for System.Data.Common and System.Data.ProviderBase

Sureshkumar T tsureshkumar at novell.com
Tue May 24 06:32:09 EDT 2005

> I'll try to keep the code as close as possible to the guidelines.


> DbParameterBase.Parent : used by DbParameterCollectionBase to track 
> collection ownership on parameters (for example it should be impossible 
> to add the same parameter to two different collections simultaneously). 
> I choose to implement this through internal property rather that 
> internal variable.


> Private variables naming : since code guide lines do no define this 
> well, I did the changes for the following reasons :
> _paramValue -> _value and _name -> _parameterName : keep private member 
> name close to property name, so the code will be more readable.

Ok, Understandable. But, name for a parameter is always parameter's
name. anyway, if you feel it is necessary, change them.

> adding  _ to parameter names : to enable easy recognize of an errors like :
> int myProperty;
> public int MyProperty
> {
>     get { return MyProperty; }
> }

here, anyway, we use CamelCase for properties and first-letter-small for
private members. we could have got the error by seeing M in return

Please feel free to post the reworked patch.


More information about the Mono-devel-list mailing list