[Mono-devel-list] TARGET_JVM Patch for MSXslScriptManager.cs

[Rafael Teixeira]

For the maintainer of that code:

Class System.Guid has an overload of ToString that receives a format
specifier, that I think should be preferred, so instead of:

string suffix = Guid.NewGuid ().ToString ().Replace ("-", String.Empty);

it should be coded as:

string suffix = Guid.NewGuid ().ToString ("N");

Have Fun,

On Thu, 31 Mar 2005 19:19:35 +0200, Andrew Skiba <andrews at mainsoft.com> wrote:
> Hello,
> 
> I'm starting to send patches for Mainsoft Visual MainWin for J2EE
> product conditional compilation code. These patches will not affect
> compilation results as long as one does not define TARGET_JVM.
> 
> ChangeLog:
> 2004-03-31      Andrew Skiba    <andrews at mainsoft.com>
> 
> * MSXslScriptManager.cs : on-the-fly compilation is not supported in
> Visual MainWin (TARGET_JVM)
> 
> 
> Index: MSXslScriptManager.cs
> ===================================================================
> --- Mono.Xml.Xsl/MSXslScriptManager.cs  (revision 42433)
> +++ Mono.Xml.Xsl/MSXslScriptManager.cs  (working copy)
> @@ -127,6 +127,9 @@
> 
>                         public object Compile (XPathNavigator node)
>                         {
> +#if TARGET_JVM
> +                               throw new NotImplementedException ();
> +#else
>                                 string suffix = Guid.NewGuid ().ToString ().Replace ("-", String.Empty);
>                                 switch (this.language) {
>                                 case ScriptingLanguage.CSharp:
> @@ -138,6 +141,7 @@
>                                 default:
>                                         return null;
>                                 }
> +#endif
>                         }
>                 }
>         }
> 
> 
> 


-- 
Rafael "Monoman" Teixeira
---------------------------------------
I'm trying to become a "Rosh Gadol" before my own eyes. 
See http://www.joelonsoftware.com/items/2004/12/06.html for enlightment.
It hurts!