[Mono-devel-list] Re: System.XML warning

[Atsushi Eno]

Hi Marek,

Oh, what you pointed out is really important. Because if all
the contributors don't want to fix any of assemblies because of
the number of warnings, it is so important matter for all the
hackers and thus we can let people hacking on mono.

OK, I'll look into all the warnings.

Atsushi Eno

Marek Safar wrote:
> Hello Eno,
> 
>>
>> Can you post it to public devel-list? Because 1)Lluis would also
>> be interested in it, for sys.xml.serialization, and 2)if there
>> was such warning messages that does not make sense that would
>> also apply to other assemblies (I think you must have sent similar
>> messages to each developers), it is waste of time that only you
>> and I discuss them.
> 
> 
> Not exactly, I have problem with so many warnings only for System.XML 
> and System.Web assemblies.
> My tactic is to address you as main developer of System.XML to reduce as 
> many as possible warnings.
> But it doesn't mean ALL, just reduce the number of warnings to 
> acceptable level (let say up to 20) and then other people can
> contribute later to fix the rest of them.
> Simply I would like to avoid warning flooding where we "unreasonably" 
> reports 60 or more warnings for one assembly.
> Many people get confused from this and mainly they don't want to start 
> fixing where warning output is so big.
> 
> Marek
> 
>>> Hello Eno,
>>>
>>> I would like to commit my next mcs patche which improves our warning 
>>> detection.
>>> However, same as in the first case I would like to reduce the number 
>>> of BCL warnings to acceptable level.
>>> I am going to enable warning CS0169 and in the attachment is list of 
>>> warnings in System.XML namespace compiled with
>>> improved mcs. Could you please have a look at this list and either 
>>> remove them or give me hint which of them can be removed (I expect 
>>> almost every).
>>>
>>> Please be noticed that this is output of mcs compiler and any other 
>>> compiler is not able to detect this warning as good as mcs does.
>>>
>>> Regards,
>>> Marek
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> System.Xml/XmlReader.cs(1051) warning CS0169: The private method 
>>> 'System.Xml.XmlReader.CheckSupport()' is never used
>>> Mono.Xml.Schema/XsdValidatingReader.cs(231) warning CS0169: The 
>>> private method 
>>> 'Mono.Xml.Schema.XsdValidatingReader.ReadTypedValueCore()' is never used
>>> Mono.Xml.XPath/DTMXPathDocument2.cs(84) warning CS0169: The private 
>>> field 'Mono.Xml.XPath.DTMXPathDocument2.nameTable' is never used
>>> Mono.Xml.XPath/DTMXPathDocument2.cs(91) warning CS0169: The private 
>>> field 'Mono.Xml.XPath.DTMXPathDocument2.nodes' is never used
>>> Mono.Xml.XPath/DTMXPathDocument2.cs(92) warning CS0169: The private 
>>> field 'Mono.Xml.XPath.DTMXPathDocument2.attributes' is never used
>>> Mono.Xml.XPath/DTMXPathDocument2.cs(93) warning CS0169: The private 
>>> field 'Mono.Xml.XPath.DTMXPathDocument2.namespaces' is never used
>>> Mono.Xml.XPath/DTMXPathDocument2.cs(96) warning CS0169: The private 
>>> field 'Mono.Xml.XPath.DTMXPathDocument2.atomicStringPool' is never used
>>> Mono.Xml.XPath/DTMXPathDocument2.cs(97) warning CS0169: The private 
>>> field 'Mono.Xml.XPath.DTMXPathDocument2.nonAtomicStringPool' is never 
>>> used
>>> Mono.Xml.XPath/DTMXPathDocument2.cs(100) warning CS0169: The private 
>>> field 'Mono.Xml.XPath.DTMXPathDocument2.idTable' is never used
>>> Mono.Xml.Xsl/GenericOutputter.cs(78) warning CS0169: The private 
>>> field 'Mono.Xml.Xsl.GenericOutputter._isVariable' is never used
>>> Mono.Xml.Xsl/XslTransformProcessor.cs(56) warning CS0169: The private 
>>> field 'Mono.Xml.Xsl.XslTransformProcessor.outputStylesheetXmlns' is 
>>> never used
>>> System.Xml/DTDReader.cs(1441) warning CS0169: The private method 
>>> 'System.Xml.DTDReader.ReadCharacterReference()' is never used
>>> System.Xml/DTDValidatingReader.cs(350) warning CS0169: The private 
>>> method 'Mono.Xml.DTDValidatingReader.OnValidationEvent( object,  
>>> System.Xml.Schema.ValidationEventArgs)' is never used
>>> System.Xml/XmlNode.cs(714) warning CS0219: The variable 'node' is 
>>> assigned but its value is never used
>>> System.Xml/XmlNodeChangedEventArgs.cs(40) warning CS0169: The private 
>>> field 'System.Xml.XmlNodeChangedEventArgs._oldValue' is never used
>>> System.Xml/XmlNodeChangedEventArgs.cs(41) warning CS0169: The private 
>>> field 'System.Xml.XmlNodeChangedEventArgs._newValue' is never used
>>> System.Xml/XmlTextReader.cs(1672) warning CS0168: The variable 
>>> 'dummyValue' is declared but never used
>>> System.Xml/XmlUrlResolver.cs(41) warning CS0169: The private property 
>>> 'System.Xml.XmlUrlResolver.webClient' is never used
>>> System.Xml/XmlParserInput.cs(178) warning CS0169: The private method 
>>> 'System.Xml.XmlParserInput.ParseCharReference( string)' is never used
>>> System.Xml/XmlParserInput.cs(190) warning CS0169: The private method 
>>> 'System.Xml.XmlParserInput.ParseKnownEntityReference( string)' is 
>>> never used
>>> System.Xml.XPath/XPathDocument.cs(473) warning CS0169: The private 
>>> method 'System.Xml.XPath.XPathDocument.Initialize( 
>>> System.Xml.XmlReader,  System.Xml.XmlSpace,  bool)' is never used
>>> System.Xml.Xsl/XslTransform.cs(337) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.Save( 
>>> System.Xml.XmlReader,  System.IO.TextWriter)' is never used
>>> System.Xml.Xsl/XslTransform.cs(604) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xsltCleanupGlobals()' is 
>>> never used
>>> System.Xml.Xsl/XslTransform.cs(611) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlNewDoc( string)' is 
>>> never used
>>> System.Xml.Xsl/XslTransform.cs(614) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlSaveFile( string,  
>>> System.IntPtr)' is never used
>>> System.Xml.Xsl/XslTransform.cs(626) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlCleanupParser()' is 
>>> never used
>>> System.Xml.Xsl/XslTransform.cs(629) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlDocDumpMemory( 
>>> System.IntPtr, ref System.IntPtr&, ref int&)' is never used
>>> System.Xml.Xsl/XslTransform.cs(632) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlFree( System.IntPtr)' 
>>> is never used
>>> System.Xml.Xsl/XslTransform.cs(649) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.valuePop( 
>>> System.IntPtr)' is never used
>>> System.Xml.Xsl/XslTransform.cs(652) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.valuePush( 
>>> System.IntPtr,  System.Xml.Xsl.UnmanagedXslTransform.xpathobject*)' 
>>> is never used
>>> System.Xml.Xsl/XslTransform.cs(655) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlXPathFreeObject( 
>>> System.Xml.Xsl.UnmanagedXslTransform.xpathobject*)' is never used
>>> System.Xml.Xsl/XslTransform.cs(658) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlXPathNewCString( 
>>> string)' is never used
>>> System.Xml.Xsl/XslTransform.cs(661) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlXPathNewFloat( 
>>> double)' is never used
>>> System.Xml.Xsl/XslTransform.cs(664) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlXPathNewBoolean( 
>>> int)' is never used
>>> System.Xml.Xsl/XslTransform.cs(667) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlXPathNewNodeSet( 
>>> System.IntPtr)' is never used
>>> System.Xml.Xsl/XslTransform.cs(670) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlXPathCastToBoolean( 
>>> System.Xml.Xsl.UnmanagedXslTransform.xpathobject*)' is never used
>>> System.Xml.Xsl/XslTransform.cs(673) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlXPathCastToNumber( 
>>> System.Xml.Xsl.UnmanagedXslTransform.xpathobject*)' is never used
>>> System.Xml.Xsl/XslTransform.cs(676) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlXPathCastToString( 
>>> System.Xml.Xsl.UnmanagedXslTransform.xpathobject*)' is never used
>>> System.Xml.Xsl/XslTransform.cs(679) warning CS0169: The private 
>>> method 'System.Xml.Xsl.UnmanagedXslTransform.xmlXPathStringFunction( 
>>> System.IntPtr,  int)' is never used
>>> System.Xml.Schema/XmlSchemaChoice.cs(172) warning CS0169: The private 
>>> method 'System.Xml.Schema.XmlSchemaChoice.ValidateRecurseLax( 
>>> System.Xml.Schema.XmlSchemaGroupBase,  
>>> System.Xml.Schema.ValidationEventHandler,  
>>> System.Xml.Schema.XmlSchema,  bool)' is never used
>>> System.Xml.Schema/XmlSchemaCollection.cs(145) warning CS0169: The 
>>> private method 'System.Xml.Schema.XmlSchemaCollection.GetSafeNs( 
>>> string)' is never used
>>> System.Xml.Schema/XmlSchemaSet.cs(134) warning CS3019: CLS compliance 
>>> checking will not be performed on 
>>> 'System.Xml.Schema.XmlSchemaSet.XmlResolver' because it is private or 
>>> internal
>>> System.Xml.Schema/XmlSchemaSerializer.cs(118) warning CS0169: The 
>>> private method 
>>> 'System.Xml.Schema.XmlSchemaSerializationWriter.WriteObject_XmlSchemaForm( 
>>> System.Xml.Schema.XmlSchemaForm,  string,  string,  bool,  bool,  
>>> bool)' is never used
>>> System.Xml.Schema/XmlSchemaSerializer.cs(147) warning CS0169: The 
>>> private method 
>>> 'System.Xml.Schema.XmlSchemaSerializationWriter.WriteObject_XmlSchemaDerivationMethod( 
>>> System.Xml.Schema.XmlSchemaDerivationMethod,  string,  string,  
>>> bool,  bool,  bool)' is never used
>>> System.Xml.Schema/XmlSchemaSerializer.cs(1094) warning CS0169: The 
>>> private method 
>>> 'System.Xml.Schema.XmlSchemaSerializationWriter.WriteObject_XmlSchemaUse( 
>>> System.Xml.Schema.XmlSchemaUse,  string,  string,  bool,  bool,  
>>> bool)' is never used
>>> System.Xml.Schema/XmlSchemaSerializer.cs(2099) warning CS0169: The 
>>> private method 
>>> 'System.Xml.Schema.XmlSchemaSerializationWriter.WriteObject_XmlSchemaContentProcessing( 
>>> System.Xml.Schema.XmlSchemaContentProcessing,  string,  string,  
>>> bool,  bool,  bool)' is never used
>>> System.Xml.Serialization/MapCodeGenerator.cs(41) warning CS0169: The 
>>> private field 
>>> 'System.Xml.Serialization.MapCodeGenerator.codeCompileUnit' is never 
>>> used
>>> System.Xml.Serialization/MapCodeGenerator.cs(45) warning CS0169: The 
>>> private field 'System.Xml.Serialization.MapCodeGenerator.codeGen' is 
>>> never used
>>> System.Xml.Serialization/SerializationCodeGenerator.cs(1911) warning 
>>> CS0169: The private method 
>>> 'System.Xml.Serialization.SerializationCodeGenerator.GenerateGetMemberValue( 
>>> System.Xml.Serialization.XmlTypeMapMember,  object,  bool)' is never 
>>> used
>>> System.Xml.Serialization/SerializationCodeGenerator.cs(2528) warning 
>>> CS0169: The private method 
>>> 'System.Xml.Serialization.SerializationCodeGenerator.GetString( 
>>> string)' is never used
>>> System.Xml.Serialization/SerializationCodeGenerator.cs(2591) warning 
>>> CS0169: The private method 
>>> 'System.Xml.Serialization.SerializationCodeGenerator.Indent()' is 
>>> never used
>>> System.Xml.Serialization/SerializationCodeGenerator.cs(2287) warning 
>>> CS0169: The private field 
>>> 'System.Xml.Serialization.SerializationCodeGenerator._hooks' is never 
>>> used
>>> System.Xml.Serialization/SerializationSource.cs(151) warning CS0169: 
>>> The private field 
>>> 'System.Xml.Serialization.MembersSerializationSource.writeAccessors' 
>>> is never used
>>> System.Xml.Serialization/SoapCodeExporter.cs(45) warning CS0169: The 
>>> private field 
>>> 'System.Xml.Serialization.SoapCodeExporter.codeNamespace' is never used
>>> System.Xml.Serialization/SoapCodeExporter.cs(46) warning CS0169: The 
>>> private field 
>>> 'System.Xml.Serialization.SoapCodeExporter.codeCompileUnit' is never 
>>> used
>>> System.Xml.Serialization/XmlCodeExporter.cs(47) warning CS0169: The 
>>> private field 
>>> 'System.Xml.Serialization.XmlCodeExporter.codeNamespace' is never used
>>> System.Xml.Serialization/XmlCodeExporter.cs(48) warning CS0169: The 
>>> private field 
>>> 'System.Xml.Serialization.XmlCodeExporter.codeCompileUnit' is never used
>>> System.Xml.Serialization/XmlCodeExporter.cs(56) warning CS0169: The 
>>> private field 'System.Xml.Serialization.XmlCodeExporter.exportedMaps' 
>>> is never used
>>> System.Xml.Serialization/XmlMapping.cs(43) warning CS0169: The 
>>> private field 'System.Xml.Serialization.XmlMapping.key' is never used
>>> System.Xml.Serialization/XmlReflectionImporter.cs(86) warning CS0169: 
>>> The private method 
>>> 'System.Xml.Serialization.XmlReflectionImporter.Reset()' is never used
>>> System.Xml.Serialization/XmlSerializationReader.cs(63) warning 
>>> CS0169: The private field 
>>> 'System.Xml.Serialization.XmlSerializationReader.w3SchemaNS' is never 
>>> used
>>> System.Xml.Serialization/XmlSerializationReader.cs(64) warning 
>>> CS0169: The private field 
>>> 'System.Xml.Serialization.XmlSerializationReader.w3SchemaNS2000' is 
>>> never used
>>> System.Xml.Serialization/XmlSerializationReader.cs(65) warning 
>>> CS0169: The private field 
>>> 'System.Xml.Serialization.XmlSerializationReader.w3SchemaNS1999' is 
>>> never used
>>> System.Xml.Serialization/XmlSerializationReader.cs(69) warning 
>>> CS0169: The private field 
>>> 'System.Xml.Serialization.XmlSerializationReader.soapNS' is never used
>>> System.Xml.Serialization/XmlSerializationReader.cs(70) warning 
>>> CS0169: The private field 
>>> 'System.Xml.Serialization.XmlSerializationReader.schema' is never used
>>> System.Xml.Serialization/XmlSerializationReader.cs(71) warning 
>>> CS0169: The private field 
>>> 'System.Xml.Serialization.XmlSerializationReader.wsdlNS' is never used
>>> System.Xml.Serialization/XmlSerializationReader.cs(72) warning 
>>> CS0169: The private field 
>>> 'System.Xml.Serialization.XmlSerializationReader.wsdlArrayType' is 
>>> never used
>>> System.Xml.Serialization/XmlSerializationReader.cs(75) warning 
>>> CS0169: The private field 
>>> 'System.Xml.Serialization.XmlSerializationReader.typeX' is never used
>>> System.Xml.Serialization/XmlSerializationReader.cs(76) warning 
>>> CS0169: The private field 
>>> 'System.Xml.Serialization.XmlSerializationReader.arrayType' is never 
>>> used
>>> System.Xml.Serialization/XmlSerializationReader.cs(77) warning 
>>> CS0169: The private field 
>>> 'System.Xml.Serialization.XmlSerializationReader.anyType' is never used
>>> System.Xml.Serialization/XmlSerializationReaderInterpreter.cs(679) 
>>> warning CS0169: The private method 
>>> 'System.Xml.Serialization.XmlSerializationReaderInterpreter.GetListCount( 
>>> System.Xml.Serialization.TypeData,  object)' is never used
>>> System.Xml.Serialization/XmlTypeMapMemberAttribute.cs(42) warning 
>>> CS0169: The private field 
>>> 'System.Xml.Serialization.XmlTypeMapMemberAttribute._dataType' is 
>>> never used
>>
>>
>>
>>
> 
>