[Mono-devel-list] patch for TypeBuilder.CreateType() and mcs

Ben Maurer bmaurer at ximian.com
Fri Mar 11 11:01:06 EST 2005

> Ben Maurer wrote:
>> On Fri, 2005-03-11 at 04:41 +0900, Atsushi Eno wrote:
>>>I noticed that TypeBuilder never throws InvalidOperationException when
>>> CreateType() is invoked twice. It is because of this change:
>>>2004-12-06  Ben Maurer  <bmaurer at ximian.com>
>>>	* TypeBuilder.cs (CreateType): Creating a type twice does not
>>>	throw in msft.
>> I have no idea why I found this change. Are there test cases in mcs
>> that break with this patch (and without the mcs one)?
> Mhm, on fixing those mcs sources I was on the wrong path; it was my
> changes to doc.cs (reverted) caused crash (and fix) with the patch on my
> xml test stuff.
> So, for now there seems no need to change mcs stuff. I retried
> tests and it worked fine without mcs changes.

Interesting. I'd like to find out why I added this patch. I wouldn't
normally be hacking stuff there, so I must have been fixing *something*.

-- Ben

More information about the Mono-devel-list mailing list