[Mono-devel-list] [PATCH] Flags handling for _wapi_recv, _recvfrom, _send, _sendto and getsockopt

[Ankit Jain]

Hi Dick,

I've split the patch and attached is the patch for the getsockopt part
which you approved. Working on the _wapi_* flags part.

Regards,
Ankit

On Mon, 28 Feb 2005 14:33:35 +0000, Dick Porter <dick at ximian.com> wrote:
> On Mon, 2005-02-28 at 19:27 +0530, Ankit Jain wrote:
> > Attached patch adds conversion of SocketFlags to linux flags required
> > for _wapi_recv, _wapi_recvfrom, _wapi_send, _wapi_sendto calls.
> 
> The patch adds non-W32 API to io-layer, which breaks the windows build.
> You should turn managed flags into platform-specific values in
> metadata/socket-io.c using the standard preprocessor defines, not
> hardcoded hex values.
> 
> >
> > I'm not sure how to handle these flags though:
> >
> > DontRoute
> > MaxIOVectorLength
> > Partial
> 
> If these are managed flags, then they have to be mapped to OS ones if
> supported, or throw an exception if not.
> 
> > Also, the patch adds handling of SocketOption.Error for getsockopt
> > which isn't handled in the existing code.
> 
> That part of the patch looks correct.
> 
> - Dick
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: getsockopt.patch
Type: text/x-diff
Size: 867 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050301/1e071741/attachment.bin