[Fwd: Re: [Fwd: Re: [Mono-devel-list] System.Data.DataSet.ReadXml reimplementation]]
kostat at mainsoft.com
Fri Jun 24 03:02:53 EDT 2005
In fact, I think this patch is not worth to commit as it optimizes
almost nothing, but makes code harder to read. If you think it's good,
please commit youself.
Atsushi Eno wrote:
> Hi Kosta,
> Maybe I had better take care of it by myself. I think there are
> some cases that we can optimize. For example when tables are already
> defined it does not require InferSchema and thus entire load won't
> be required. However similar things also happen to XmlDataReader,
> so they should be taken care as a whole. Please feel free to
> commit this patch but I'll look into them at some stage again.
> Atsushi Eno
> Konstantin Triger wrote:
>> Hi Eno,
>> I don't see it in mailing list so resending.
>> I made the changes we talked about, bt it turns out they probably
>> won't make a big diff (see attached patch)
>> The problem is that I have to collect almost always:
>> XmlReadMode.InferSchema: in order to be able to skip if "schema" is
>> XmlReadMode.Auto: as I don't know what's gonna be.
>> XmlReadMode.DiffGram: wait for diffgram - very uncommon case, but
>> have a test (MonoTests.System.Data.DataSetTest.ReadWriteXmlDiffGram).
>> XmlReadMode.IgnoreSchema: to be able to ignore the schema if it's found.
>> From the other side in most cases the schema or diffgram element
>> will be as root or its child, so nothing would be collected anyway.
>> Konstantin Triger
More information about the Mono-devel-list