[Mono-devel-list] Re: Patch for standardizing Mainsoft DataSetTest tests for System.Data

[tsureshkumar]

Eyal Alaluf wrote:
> Hi, all.
> 
> The attached patch replaces the Mainsoft System.Data.DataSet tests with a
> standardized Mono tests style test - collecting a lot of separate per-method
> test classes into one test class that tests DataSet.
> One issue that I'd like to mention is that I used as namespace
> 'MonoTests_System.Data' rather then 'MonoTests.System.Data' for the test.
> The reason is that ptherwise code like the following:
>   System.Text.StringBuilder resultXML = new System.Text.StringBuilder();
> does not compile. It gives the error
>   Test\System.Data\DataSetTest2.cs(350,11): error CS0234: The type or namespace name 'Text' does not exist in the class or namespace 'MonoTests.System' (are you missing an assembly reference?)
> The problem is that the compiler interprets the use of 'System' as
> MonoTests.System and not as the root 'System'.
> I consider adding a using directive and not using a full scope as a workaround
> to the problem and not a solution.

IMO, "using" is the right solution as we have not used full scoped 
classes anywhere in other tests. "StringBuilder resultXML = new 
StringBuilder();" is simpler than full scoped one.  Apart from that, 
feel free to commit.

suresh.