[Mono-devel-list] [PATCH] System.Web.Service protocols

Lluis Sanchez lluis at ximian.com
Mon Jun 6 07:50:21 EDT 2005

El dl 06 de 06 del 2005 a les 12:08 +0200, en/na Kornél Pál va escriure:
> > Feel free to commit. However, please split that 5 line "if" to make
> > easier to understand what is it actually checking.
> I realized that I put it into a single "if" because it's difficult to split
> DummyHttpHandler is used when this whole statement is false.
> So there should be redundant new DummyHttpHandler () creations or goto
> should be used.
> I think using redundant code increases a prossibity of new or unfixed bug as
> it's esay to modify only one of them.

> And it's better to assing value to the variables inside if, to make the code
> faster.
> If you have a good solution to simplify this piece of code please let me
> know.

I would probably have avoided the assignment in the condition, and the
global condition negation, even if that would have required more code,
because they make the code harder to read (btw, I don't think that one
line of code can be considered "redundant code"). But I don't think it
is worth a discussion, so feel free to commit.

> Kornél
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list

More information about the Mono-devel-list mailing list